Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

chore: Upgrade to Angular 2 RC.5 #3

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Conversation

MikeRyanDev
Copy link
Member

Upgrades the store log monitor to Angular RC.5

BREAKING CHANGE:

With the introduction of NgModules, setting up StoreLogMonitor has changed.

Before:

import { instrumentStore } from '@ngrx/store-devtools';
import { useLogMonitor, StoreLogMonitorComponent } from '@ngrx/store-log-monitor';

@Component({
  providers: [
    instrumentStore({ monitor: useLogMonitor() })
  ],
  directives: [
    StoreLogMonitorComponent
  ]
})
export class AppComponent { }

After:

import { StoreDevtoolsModule } from '@ngrx/store-devtools';
import { StoreLogMonitorModule, useLogMonitor } from '@ngrx/store-log-monitor';

@NgModule({
  imports: [
    StoreDevtoolsModule.instrumentStore({ monitor: useLogMonitor() }),
    StoreLogMonitorModule
  ]
})
export class AppModule { }

Upgrades the store log monitor to Angular RC.5

BREAKING CHANGE:

With the introduction of NgModules, setting up StoreLogMonitor has changed.

Before:

```ts
import { instrumentStore } from '@ngrx/store-devtools';
import { useLogMonitor, StoreLogMonitorComponent } from '@ngrx/store-log-monitor';

@component({
  providers: [
    instrumentStore({ monitor: useLogMonitor() })
  ],
  directives: [
    StoreLogMonitorComponent
  ]
})
export class AppComponent { }
```

After:
```ts
import { StoreDevtoolsModule } from '@ngrx/store-devtools';
import { StoreLogMonitorModule, useLogMonitor } from '@ngrx/store-log-monitor';

@NgModule({
  imports: [
    StoreDevtoolsModule.instrumentStore({ monitor: useLogMonitor() }),
    StoreLogMonitorModule
  ]
})
export class AppModule { }
```
@brandonroberts
Copy link
Member

Test suite is broken unless I install [email protected]. Otherwise LGTM

  Uncaught Error: Missing: SyncTestZoneSpec
  at /projects/ngrx/store-log-monitor/tests.js:9418 <- webpack:///~/zone.js/dist/jasmine-patch.js:66:0

@MikeRyanDev MikeRyanDev merged commit 29656f3 into ngrx:master Aug 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants