Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for multiple returned values #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

scott-gunn
Copy link

Fixed a bug where only the first value was being computed, and refactored the unit test into its own section as it should have been done originally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akalotkin
Copy link

@scott-gunn, I think we should add unit test that covers the issue.

@scott-gunn
Copy link
Author

@scott-gunn, I think we should add unit test that covers the issue.

Deequ unit tests aren't built to handle this case, each test just unit tests the individual metric for a single value. They don't go through a runtime that spits out multiple values. I am going to add a unit test to our in-house mdl-dqa project though as it can handle it since it runs through the runAnomalyChecks function which looks like it will hit this bug.

@akalotkin
Copy link

@scott-gunn, I think we should add unit test that covers the issue.

Deequ unit tests aren't built to handle this case, each test just unit tests the individual metric for a single value. They don't go through a runtime that spits out multiple values. I am going to add a unit test to our in-house mdl-dqa project though as it can handle it since it runs through the runAnomalyChecks function which looks like it will hit this bug.

I think it should be possible to add multiple analyzers to a single test. Like here:

"return the proper exception when the number of max histogram bins is too big" in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants