ansible: update OpenSSL 3.0 to use quictls/openssl #2613
Conversation
| @@ -58,7 +58,7 @@ ENV OPENSSL300DIR /opt/openssl-3.0.0 | |||
|
|
|||
| RUN mkdir -p /tmp/openssl_3.0.0 && \ | |||
| cd /tmp/openssl_3.0.0 && \ | |||
| curl -sL https://www.openssl.org/source/openssl-3.0.0-alpha13.tar.gz | tar zxv --strip=1 && \ | |||
| curl -sL https://github.com/quictls/openssl/archive/refs/tags/openssl-3.0.0-alpha13.tar.gz | tar zxv --strip=1 && \ | |||
There was a problem hiding this comment.
Does this contain the quic patches?
https://github.com/quictls/openssl/releases/tag/openssl-3.0.0-alpha13 points to quictls/openssl@88df2c0 and I don't see any of the quic commits in https://github.com/quictls/openssl/commits/openssl-3.0.0-alpha13 (compared to https://github.com/quictls/openssl/commits/openssl-3.0.0-alpha13+quic).
There was a problem hiding this comment.
I thought they would be included but perhaps they are not. I'll take a closer look. And yes we should hold off a day or tow so that we can update to alpha14 👍
There was a problem hiding this comment.
Is it alright to use git clone instead?
|
FWIW the OpenSSL project released 3.0.0-alpha14 today: https://mta.openssl.org/pipermail/openssl-announce/2021-April/000199.html |
|
btw I've just updated to alpha14 on the containers and there seems to be a couple of broken TLS tests -- for some reason the |
|
@rvagg About the failing tests, I'm seeing two failure which are |
|
@danbev those are the two tests failing in the CI: https://ci.nodejs.org/job/node-test-commit-linux-containered/26389/nodes=ubuntu1804_sharedlibs_openssl300_x64/ |
|
@richardlau I've got a fix for one of then and I can skip the other until I've sorted it out. Should I create PRs against master for them? |
|
@danbev Yes, please do. |
This commit update the version of OpenSSL 3.0 to use the quictls/openssl fork. This for will be used until upstream OpenSSL includes support for the QUIC protocol. At that point we can switch back to using upstream again.
danbev
force-pushed
the
update_openssl3_quic
branch
from
dd5a000 to
417f5d9
Compare
|
@richardlau The latest commit here is using git to clone |
Awesome, thanks! |
ansible/roles/docker/templates/ubuntu1804_sharedlibs.Dockerfile.j2
Outdated
Show resolved
Hide resolved
ansible/roles/docker/templates/ubuntu1804_sharedlibs.Dockerfile.j2
Outdated
Show resolved
Hide resolved
|
Deployed this (with openssl3.0.0-alpha14+quic) to the docker hosts and started a test build: https://ci.nodejs.org/job/node-test-commit-linux-containered/26738/nodes=ubuntu1804_sharedlibs_openssl300_x64/ |
This commit update the version of OpenSSL 3.0 to use the quictls/openssl
fork. This for will be used until upstream OpenSSL includes support for
the QUIC protocol. At that point we can switch back to using upstream
again.