Update README #34
Update README #34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 79.88% 79.88%
=======================================
Files 10 10
Lines 353 353
=======================================
Hits 282 282
Misses 71 71Continue to review full report at Codecov.
|
| @@ -44,8 +47,7 @@ This one is inspired by Evan Lucas's [node-review](https://github.com/evanlucas/ | |||
| - [x] Generate `Fixes` | |||
| - [x] Generate `Refs` | |||
| - [x] Check for CI runs | |||
| - [ ] Check if commiters match authors | |||
| - Only when `"authorAssociation": "FIRST_TIME_CONTRIBUTOR"` | |||
| - [x] Check if commiters match authors | |||
| - [x] Check 48-hour wait | |||
| - [x] Check two TSC approval for semver-major | |||
| - [ ] Warn new commits after reviews | |||
There was a problem hiding this comment.
Hmm..also I am not quite sure how this one should be handled because in practice, we still count reviews that give approval before new commits, as long as they don't object afterwards.
There was a problem hiding this comment.
So, there was a conversation at some point that people who comment "LGTM" want that to be dismissed if a new commit comes in.
nodejs/node#13413 (comment)
There was a problem hiding this comment.
Hmm..I think I can not get a conclusion from that thread, or did I miss something? Should we open an issue in the core repo to get this settled?
No description provided.