timer: call list.start regardless new or not

[abbr]

Call start regardless whether list is new
or not to prevent incorrect active_handles
count.

Fixes issue #25831.

[garrettsickles]

What a great fix! This should be included asap!

[leo60228]

+1

[misterdjules]

To paraphrase my comment in #25831:

While deasync seems to rely too much on Node.js' internals, the fix suggested in [this PR] actually looks good to me so far, and thus I think I would be inclined to merge it in.

[jasnell]

This looks good but would you be able to include a test case for it?

[abbr]

@jasnell, a test case would require either writing a c++ module or obtaining deasync via npm. I cannot find any existing cases under test/simple setup this way. In test/addons there are test cases written in c++ but that folder doesn't seem to be included in make test. Do you have any suggestion where to put the test case?

[jonathanleang]

👍

[jonathanleang]

[thefourtheye]

cc @Fishrock123

[vkurchatkin]

If it's impossible to write a test without external dependencies, then it's not a bug

[Fishrock123]

I think this is a bug. My tired self does not think that the proposed patch could actually fix this. We'll see tomorrow maybe.

[abbr]

I have added a test case, without any dependencies. Confirmed test case caused existing version 0.12.7 hung but passed with the fix.

[Fishrock123]

@abbr could we move this issue to https://github.com/nodejs/node? I'd prefer to review it there.

[vkurchatkin]

@Fishrock123 so what's the bug? running uv_run is clearly not supported so it should be something else

[abbr]

@Fishrock123, I have ported this pr to nodejs/node#2788

[ChALkeR]

Closing here.