test: improve fs coverage

nodejs · May 3, 2021 · 04dc1f1 · 04dc1f1
1 parent 68e6673
commit 04dc1f1
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/test/parallel/test-fs-read.js b/test/parallel/test-fs-read.js
@@ -78,13 +78,20 @@ assert.throws(
   }
 );
 
-['buffer', 'offset', 'length'].forEach((option) =>
+['buffer', 'offset', 'length'].forEach((option) => {
   assert.throws(
     () => fs.read(fd, {
       [option]: null
     }),
     `not throws when options.${option} is null`
-  ));
+  );
+  assert.throws(
+    () => fs.readSync(fd, {
+      [option]: null
+    }),
+    `not throws when options.${option} is null`
+  );
+});
 
 assert.throws(
   () => fs.read(null, Buffer.alloc(1), 0, 1, 0),

diff --git a/test/parallel/test-fs-readfile.js b/test/parallel/test-fs-readfile.js
@@ -52,6 +52,23 @@ for (const e of fileInfo) {
     assert.deepStrictEqual(buf, e.contents);
   }));
 }
+// Test readFile size too large
+{
+  const kIoMaxLength = 2 ** 31 - 1;
+
+  const file = path.join(tmpdir.path, `${prefix}-too-large.txt`);
+  fs.writeFileSync(file, Buffer.from('0'));
+  fs.truncateSync(file, kIoMaxLength + 1);
+
+  fs.readFile(file, common.mustCall((err) => {
+    assert.strictEqual(err.name, 'RangeError');
+    assert.strictEqual(err.code, 'ERR_FS_FILE_TOO_LARGE');
+  }));
+  assert.throws(() => {
+    fs.readFileSync(file);
+  }, { code: 'ERR_FS_FILE_TOO_LARGE', name: 'RangeError' });
+}
+
 {
   // Test cancellation, before
   const signal = AbortSignal.abort();