url: verify domain is not empty after "ToASCII"

Port of whatwg/url#497 PR-URL: #33770 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Sep 16, 2020 · 69ef4c2 · 69ef4c2
1 parent 4831278
commit 69ef4c2
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -779,6 +779,8 @@ bool ToASCII(const std::string& input, std::string* output) {
   MaybeStackBuffer<char> buf;
   if (i18n::ToASCII(&buf, input.c_str(), input.length()) < 0)
     return false;
+  if (buf.length() == 0)
+    return false;
   output->assign(*buf, buf.length());
   return true;
 }