Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: make var to const if possible #13797

Closed
wants to merge 1 commit into from
Closed

dns: make var to const if possible #13797

wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

@XadillaX XadillaX commented Jun 19, 2017 •
edited
Loading

Refs: #13732

Checklist
Affected core subsystem(s)

dns

@nodejs-github-bot nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Jun 19, 2017
@XadillaX
Copy link
Contributor Author

How about var to let?

@XadillaX
Copy link
Contributor Author

duplicate with #13756

@XadillaX XadillaX closed this Jun 19, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 19, 2017

How about var to let?

I think the gating factor is whether there will be deoptimisations in V8. If you check and confirm that there won't be then I don't see the harm in raising a PR (and I'd be +1 on it). If we move away from var entirely we can use the no-var and prefer-const eslint rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XadillaX @gibfahn @nodejs-github-bot