From d02deda8ccf6673a37cb7b20876d8d8d70048bdd Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 6 Mar 2019 13:44:11 -0800 Subject: [PATCH 1/2] doc: edit "Involving the TSC" Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. --- COLLABORATOR_GUIDE.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 281077a91cc058..c8bb7efcbd052c 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -374,13 +374,12 @@ deprecation level of an API. ### Involving the TSC Collaborators may opt to elevate pull requests or issues to the [TSC][]. -This should be done where a pull request: +Do this if a pull request or issue: - is labeled `semver-major`, or - has a significant impact on the codebase, or -- is inherently controversial, or -- has failed to reach consensus amongst the Collaborators who are - actively participating in the discussion. +- is controversial, or +- is at an impasse among Collaborators who are participating in the discussion. Assign the `tsc-review` label or @-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. From 89c405671b11a9ca78ad10a1c84694fabcdf0508 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Wed, 6 Mar 2019 13:55:16 -0800 Subject: [PATCH 2/2] Update COLLABORATOR_GUIDE.md Co-Authored-By: Trott --- COLLABORATOR_GUIDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index c8bb7efcbd052c..8e9cc2be1b3c3f 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -379,7 +379,7 @@ Do this if a pull request or issue: - is labeled `semver-major`, or - has a significant impact on the codebase, or - is controversial, or -- is at an impasse among Collaborators who are participating in the discussion. +- is at an impasse among Collaborators who are participating in the discussion. Assign the `tsc-review` label or @-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].