Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: generate compile commands with py3 #30748

Closed
wants to merge 1 commit into from
Closed

build: generate compile commands with py3 #30748

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

Fixes failures on ./configure -C with python3.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@legendecas
build: generate compile commands with py3
a7bfe51 
Fixes failures on `./configure -C` with python3.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Dec 1, 2019
@targos
Copy link
Member

targos commented Dec 1, 2019

this change is included in #30563

@legendecas
Copy link
Member Author

Closed for preferring #30563.

@legendecas legendecas closed this Dec 1, 2019
@legendecas legendecas deleted the compile-commands-py3 branch December 1, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @targos @devnexen @nodejs-github-bot