From 327557f43166cd3d8d1d2696a60e88c494e21947 Mon Sep 17 00:00:00 2001 From: Ken Perkins Date: Thu, 26 Feb 2015 10:36:40 -0800 Subject: [PATCH] Adding a test for undefined value in OutgoingMessage.setHeader As a result of 979d0ca8 there is a new check for undefined values on OutgoingMessage.setHeader. This commit introduces a test for this case. --- test/parallel/test-http-write-head.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/parallel/test-http-write-head.js b/test/parallel/test-http-write-head.js index b0cab236780358..acd2a6058dd526 100644 --- a/test/parallel/test-http-write-head.js +++ b/test/parallel/test-http-write-head.js @@ -18,6 +18,17 @@ var s = http.createServer(function(req, res) { } assert.ok(threw, 'Non-string names should throw'); + // undefined value should throw, via 979d0ca8 + threw = false; + try { + res.setHeader('foo', undefined); + } catch (e) { + assert.ok(e instanceof Error); + assert.equal(e.message, '`value` required in setHeader("foo", value).'); + threw = true; + } + assert.ok(threw, 'Undefined value should throw'); + res.writeHead(200, { Test: '2' }); res.end(); });