Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Liran Tal as group member. #80

Merged
merged 1 commit into from
Jan 4, 2018
Merged

add Liran Tal as group member. #80

merged 1 commit into from
Jan 4, 2018

Conversation

vdeturckheim
Copy link
Member

@vdeturckheim vdeturckheim commented Dec 13, 2017

I would like to nominate Liran Tal as a member of te Security WG:

Since our next meeting is only next month, if @nodejs/security-wg accepts it, I would like to have Liran becoming a member ASAP in order to have him join the ecosystem triage team.

@Trott
Copy link
Member

Trott commented Dec 14, 2017

@vdeturckheim I think the people to ping would be @nodjes/tsc. Decisions about membership in @nodejs/security and in the triage team are currently made by @nodejs/tsc. (Related: We should probably land #70 pretty soon.)

If I'm not misunderstanding, I'd suggest adding a tsc-agenda label to this and request review from TSC.

@vdeturckheim
Copy link
Member Author

@Trott I went too quick and pinged 'security' instead of 'security-wg'. Sorry about this :/

@vdeturckheim
Copy link
Member Author

So heads up @nodejs/security-wg O:-)

@lirantal
Copy link
Member

Thanks @vdeturckheim and guys for your support!
Let me know if there's anything required on my side.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to have him join the team as we need people to triage/help with the third party vulnerabilities.

At this point its only a few days to the next meeting so I suggest we just wait until then and provide we have agreement there we'll go ahead.

@vdeturckheim
Copy link
Member Author

As of today's meeting, I'm merging this. @cjihrig or @mhdawson can you invite Liran to the Node.js org please?

@vdeturckheim vdeturckheim merged commit 712e9df into nodejs:master Jan 4, 2018
@vdeturckheim vdeturckheim deleted the add_liran branch January 4, 2018 20:38
@mhdawson
Copy link
Member

mhdawson commented Jan 4, 2018

@vdeturckheim done. He should get an invite to the org and the security-wg team

@vdeturckheim
Copy link
Member Author

Awesome, thanks!

@mhdawson
Copy link
Member

mhdawson commented Jan 4, 2018

@lirantal one thing I missed mentioning is that we ask all those who are part of the org have 2FA enabled. Can you please look into doing that within the next few weeks.

@lirantal
Copy link
Member

lirantal commented Jan 5, 2018

Thanks guys! Excited to get started with anything I can help with :-)
I have 2FA enabled for GitHub and npmjs for quite a while now so we're good on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants