Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to use core stream #17

Closed
ronag opened this issue May 2, 2020 · 1 comment · Fixed by #27
Closed

Option to use core stream #17

ronag opened this issue May 2, 2020 · 1 comment · Fixed by #27

Comments

@ronag
Copy link
Member

ronag commented May 2, 2020 •
edited
Loading

Would it be possible and make sense to add a runtime option to use core streams instead of readable-stream and eos? In particular in terms of the response body.
@ronag ronag changed the title option to use core stream Option to use core stream May 2, 2020
@mcollina
Copy link
Member

mcollina commented May 2, 2020

Go ahead and send a PR. I plan to release a version of readable-stream cut from v14 later this year.

ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
1ed9ee5 
Fixes: nodejs#17
@ronag ronag mentioned this issue May 3, 2020
Merged
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
62c0c9c 
Fixes: nodejs#17
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
3fb9af0 
Fixes: nodejs#17
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
0555f16 
Fixes: nodejs#17
@ronag ronag mentioned this issue May 3, 2020
Closed
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
e1162a6 
Fixes: nodejs#17
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
32957b9 
Fixes: nodejs#17
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
2ff8adc 
Fixes: nodejs#17
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
19b4ee7 
Fixes: nodejs#17
ronag added a commit to nxtedition/undici that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation
fcaf7e3 
Fixes: nodejs#17
mcollina pushed a commit that referenced this issue May 3, 2020
@ronag
feat: allow overriding stream implementation (#27)
4c0c428 
Fixes: #17
@renovate renovate bot mentioned this issue Aug 19, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mcollina @ronag