Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the root secret from pod env variables #1533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Neon-White
Copy link
Contributor

Explain the changes

  1. As reported in DFBUGS-1608, the NooBaa root secret would be unintentionally revealed in some cases. This PR aims to remediate the issue by removing legacy code that was used to pass the secret via env params, before it was changed to be passed via a file mount

Issues: Fixed #xxx / Gap #xxx

  1. DFBUGS-1608

Testing Instructions:

  1. Deploy NooBaa on an AWS IPI Thales configuration
  2. Make sure NOOBAA_ROOT_SECRET does not show in the env variables of endpoint and core pods
  • Doc added/updated
  • Tests added

@liranmauda
Copy link
Contributor

LGTM,
We need to figure out if the upgrade path would be affected.
If it works, we can manage it, and create a PR on core that removes the env variable.
@romayalon for the core side, do we use this env on NC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants