Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notation login returns unfriendly error #156

Closed
toddysm opened this issue Mar 23, 2023 · 4 comments
Closed

Notation login returns unfriendly error #156

toddysm opened this issue Mar 23, 2023 · 4 comments
Labels
bug Something isn't working ux
Milestone

Comments

@toddysm
Copy link
Contributor

toddysm commented Mar 23, 2023

Related to the following comment on the documentation #149 (comment) trying to sign into Docker Hub I get the following error:

~> notation login docker.io                                                                              
Error: failed to store credentials: error storing credentials - err: no credentials username, out: `no credentials username`

We need to fix the error message and provide consistent experience with other tools to prompt for the username and password instead.

@FeynmanZhou
Copy link
Member

@toddysm I think this issue has been covered by notaryproject/notation#503. There is already a corresponding PR to address this login experience at notaryproject/notation#566. We plan to improve this experience in RC.4.

If this issue is a feature request to Notation instead of a doc change, it duplicates with notaryproject/notation#503. We should consider closing it or transferring it to the Notation repo.

@toddysm
Copy link
Contributor Author

toddysm commented Mar 24, 2023

I am fine closing this one in this repo but I would like to make sure that notaryproject/notation#503 and notaryproject/notation#566 implement better error messages.

@yizha1 yizha1 modified the milestones: RC-4, 1.0.0 Apr 24, 2023
@yizha1
Copy link
Contributor

yizha1 commented May 10, 2023

@toddysm Is it OK to close this issue, since notaryproject/notation#503 and notaryproject/notation#503 were closed.

@zr-msft
Copy link
Collaborator

zr-msft commented May 11, 2023

@toddysm @yizha1 closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux
Projects
Status: Done
Development

No branches or pull requests

4 participants