-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Add "max-len": ["error", 80]
to .eslintrc.json and make it work
#2029
Comments
You can configure max-len to ignore lines with long strings or regexes or urls; i suggest doing so. Example: https://github.com/airbnb/javascript/blob/2c5c88d0487db3024e8a20bb20f46933a03dd8aa/packages/eslint-config-airbnb-base/rules/style.js#L205 |
@isaacs |
Could I take on this issue if no one is currently working on it? @isaacs |
You can do it @Gurinderp |
Can you assign me on this issue ? @isaacs |
Hi @isaacs is anyone still working on the case? If no, could you please explain to me a little more about the project, I'm a newbie and would like to contribute, or is the issue is closed? |
@darcyclarke - @isaacs, so I just added the "max-len" to the .eslintrc.json, but what do you mean with make it work? |
Well, there are quite a few places (iirc?) that are longer than 80 chars. So |
Looks like #2361 has been merged. Shouldn't this issue be closed too? |
We have a lot of long lines, let's shorten them.
Be smart about making the choices to split lines, no fake internet points for cutting strings and making them unreadable!
The text was updated successfully, but these errors were encountered: