-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLs using IP or other hostname for images in meta bundle #672
Comments
How are your asset volumes set up? It looks to me like they may not be explicitly declared? Also how is your |
I'm going to assume it's this: https://twitter.com/nystudio107/status/1074429502615379968 https://docs.craftcms.com/v3/sites.html#creating-a-site
Basically, if you use the So explicitly set the |
Apologies for the late reply! I do have my @web and siteUrl set definitively. |
Can you show me how you're setting this @mizziness ? |
Also I'd need to see how you're setting the URL for your Asset Volumes. |
Here we go! This is in my
It checks for $domain this way:
The default fall-back should always be one of the fully-qualified domains. But on a site hard-coded to have a siteUrl of the official domain, I still see the server IP address and other domain. Asset Volume Info:Base Url:
|
@khalwat Info fully provided - would you mind taking a look when you can? It's still an issue. |
@mizziness I don't know exactly what would be causing this issues, except to say that all SEOmatic does is use the built-in Craft So this is going to very likely be some kind of a Craft config setup issue. What you're showing me is a URL for an image that seems incorrect... is it possible to see the Asset Volume setup/config for the Asset Volume that this image is coming from? Assets don't use your |
@khalwat I had edited my previous post with more info, sorry! Let me try and explain better:
|
The Site URL Override is not something you'd normally use. It is only intended for "headless" setups where Craft isn't serving the content. Show me how the alias |
Okay, good, I was hoping that was an edge-case setting.
Long story short, it's in the
P.S. Thank you for putting up with me :) |
hmmmm. Well, that certainly should always be defined then. I still think this will end up being some kind of config setting, but happy to set up a video conference day/time with you to have a look if you like |
Example of this is live on our website at https://applause.com. If you view the source, the plugin seems to be spitting out a JSON blob with meta bundle data. However, under
graph
, we see the following incorrect urls:I would expect both of these urls should be using either the
baseUrl
or thesiteUrl
. I've also tried deleting and re-adding all of the images under Global settings, but to no avail.The data seems to be stored in the database under
seomatic_metabundles
with the sourceType (et al) set to__GLOBAL_BUNDLE__
.Possibly related to #577
The text was updated successfully, but these errors were encountered: