Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Searching by validator address doesn't open up validators page, but accounts for non-registered validators #1767

Open
1 task done
matevz opened this issue Feb 19, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@matevz
Copy link
Member

matevz commented Feb 19, 2025

Is there an existing issue for this?

  • I have searched the existing issues

SUMMARY

For validators without metadata, searching by address doesn't return validators page, but accounts page

STEPS TO REPRODUCE

  1. Search for the validator's address that doesn't have registered metadata. For example oasis1qzv2rktycpcykhudyvg5l6u75v08lpfcw5nt7aj5
  2. The result link points to https://explorer.oasis.io/mainnet/consensus/address/oasis1qzv2rktycpcykhudyvg5l6u75v08lpfcw5nt7aj5 instead of https://explorer.oasis.io/mainnet/consensus/validators/oasis1qzv2rktycpcykhudyvg5l6u75v08lpfcw5nt7aj5

If searching for an address of a registered validator, e.g. Stakefish (address oasis1qq3xrq0urs8qcffhvmhfhz4p0mu7ewc8rscnlwxe), it correctly points to the validators page.

May be related to #1729

EXPECTED BEHAVIOR

If the resulting node is a validator, then the link should point to the validators page regardless of metadata.

@matevz matevz added the bug Something isn't working label Feb 19, 2025
@buberdds
Copy link
Contributor

  1. Bug in ConsensusAccountLink, wrong link can be rendered in multiple places in the app Rely on validator address presence not name in ConsensusAccountLink #1768
  2. Search result View account button -> ResultsGroupByType: we prob want to create 'validator' group for resultType

@buberdds buberdds self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants