Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install ts-web/core package first #292

Merged
merged 2 commits into from
Jul 20, 2021
Merged

ci: install ts-web/core package first #292

merged 2 commits into from
Jul 20, 2021

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Jul 19, 2021

fixes #291

seems npm now runs 'lifecycle scripts' during workspace install npm/cli#2900 npm/arborist@5a4c106. from convenient, no? we save a few npm run prepare steps.

but it does kind of a shoddy job of it. it runs all the packages' prepare scripts at the same time, concurrently. however, other dev tools we use, such as tsc, rely on dependencies already being built, so this broke things for us.

for now, we manually encode that core is lower (?) in the dependency graph and manually do that first. then we install the other packages, although I'm pretty sure that recompiles core 🙄

@pro-wh pro-wh added bug Something isn't working c:client-sdk/typescript Category: TypeScript client SDK c:testing Category: testing labels Jul 19, 2021
@pro-wh pro-wh requested review from kostko and ptrus as code owners July 19, 2021 21:40
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #292 (8527aa1) into main (f14c6b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   70.70%   70.70%           
=======================================
  Files          57       57           
  Lines        3455     3455           
=======================================
  Hits         2443     2443           
  Misses        992      992           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14c6b6...8527aa1. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/bugfix/prepare branch from dbcdce0 to 8527aa1 Compare July 19, 2021 21:48
@kostko kostko merged commit ebf1f29 into main Jul 20, 2021
@kostko kostko deleted the pro-wh/bugfix/prepare branch July 20, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c:client-sdk/typescript Category: TypeScript client SDK c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ts-web: no longer builds on CI
3 participants