ci: install ts-web/core package first #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #291
seems npm now runs 'lifecycle scripts' during workspace install npm/cli#2900 npm/arborist@5a4c106. from convenient, no? we save a few
npm run prepare
steps.but it does kind of a shoddy job of it. it runs all the packages'
prepare
scripts at the same time, concurrently. however, other dev tools we use, such as tsc, rely on dependencies already being built, so this broke things for us.for now, we manually encode that
core
is lower (?) in the dependency graph and manually do that first. then we install the other packages, although I'm pretty sure that recompilescore
🙄