Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Obs x64 crash every time with VST plugin "pitchproof" enabled when exit. #2638

Closed
PHCLMicoTW opened this issue Apr 4, 2020 · 3 comments

Comments

@PHCLMicoTW
Copy link

PHCLMicoTW commented Apr 4, 2020

Platform

Operating system and version: Windows 10 x64 build 18362
OBS Studio version: Obs 25.0.1 64-bit (Also occur on older version).

Expected Behavior

Plugin work fine and:
Type 1: Closing and save all the data like normally.
Type 2: Can be disable plugin in sound filter dialog.

Current Behavior

Plugin work fine but:
Type 1: Obs crash on exit every time with VST plugin "pitchproof" enabled.
Type 2: When disabling plugin in sound filter, Obs will crash like when it exiting.
Note: After remove plugin it will save sound filter setting (some times not), but others don't.

Logs: obs crashes logs.zip

Steps to Reproduce

  1. Install VST plugin "pitchproof" to the computer.

  2. Add VST 2.x plugin filter to any of sound source and choose "pitchproof-x64".

  3. To crash Obs:
    2-1. Close Obs.
    2-2. Remove "pitchproof" from sound filters list.

  4. Obs crashed.

Video: (Youtube)
Reproducing Obs "pitchproof" plugin crash.
P.S. I forgot I'm using another OBS for recording, so you can't hear what's the plugin sound like, but it work find.

Additional information

Only "pitchproof" will lead to Obs crash, I tested another plugin "GSnap" (which is a autotune plugin) it work totally fine.

Edited

Add plugin download page here:
Pitchproof is a free audio plug-in that can shift the pitch of the input.

@WizardCM
Copy link
Member

WizardCM commented Apr 4, 2020

I have been able to reproduce this.

Where the error occurs:
https://github.com/obsproject/obs-vst/blob/master/VSTPlugin.cpp#L185

image

Here's the strangest part - the VST window in this case is titled based on the name of another filter, not the source itself.

image

@notr1ch
Copy link
Member

notr1ch commented Apr 4, 2020

Looks like this is an issue with the VST plugin if it's crashing inside the DLL after calling close.

@Fenrirthviti
Copy link
Member

Closing as this appears to be an issue with the plugin itself, not the OBS VST plugin. However, that said, if the plugin developer wishes to contest that, this issue should be reopened on the obs-vst repo instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants