Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depending on alias is not transitive #3415

Closed
ejgallego opened this issue Apr 22, 2020 · 2 comments
Closed

Depending on alias is not transitive #3415

ejgallego opened this issue Apr 22, 2020 · 2 comments
Labels

Comments

@ejgallego
Copy link
Collaborator

Hi folks,

I'm not sure if this intended but posting here for discussion. Assume a dune file:

(alias
 (name foo)
 (deps (source_tree dir)))

(rule
 (alias bar)
 (deps (alias foo))
 (action (with-stdout-to out (bash "cat dir/dep"))))

dune build @bar will build out correctly the first time; however it we update dir/dep out is not rebuilt.

Dune 2.5.1 (back to 2.1.1), OCaml 4.10, Linux

@ghost
Copy link

ghost commented Apr 28, 2020

This looks like a bug indeed. Morally, depending on (alias foo) should depend on the expansion of foo, which should include dir/dep because of the (deps (source_tree dir)).

@aalekseyev
Copy link
Collaborator

This issue should be fixed by #4303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants