Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune subst output depends on git version #4911

Closed
nojb opened this issue Sep 9, 2021 · 2 comments
Closed

dune subst output depends on git version #4911

nojb opened this issue Sep 9, 2021 · 2 comments

Comments

@nojb
Copy link
Collaborator

nojb commented Sep 9, 2021

Not sure this is something that should be fixed by dune, but am opening the issue just to put it out: dune subst calls git describe, but the number of digits used in the "short hash" depends on the version of git as far as I can see. Recently I was bitten by this where the same commit built under Unix (Ubuntu 18.04) and Windows (Cygwin) ended up with different strings substituted.

git describe accepts a --abbrev=<n> argument to specify how many digits to use in the short hash, but it is not clear that using this is the right thing to do.

@jberdine
Copy link
Contributor

jberdine commented Sep 9, 2021

Is this covered by #4857 or does subst use a different path than build-info?

@nojb
Copy link
Collaborator Author

nojb commented Sep 9, 2021

Is this covered by #4857 or does subst use a different path than build-info?

From a quick glance it looks like it is. Thanks for the pointer!

@nojb nojb closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants