Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization flag #1025

Closed
drjdn opened this issue Jun 11, 2020 · 3 comments
Closed

Optimization flag #1025

drjdn opened this issue Jun 11, 2020 · 3 comments
Labels

Comments

@drjdn
Copy link

drjdn commented Jun 11, 2020

I recently updated to version 3.6.0 and dune was complaining about the flag "--opt=3". This makes sense as:

js_of_ocaml build-runtime --help

doesn't document the --opt=[NUM] option. Removing the option from dune fixes the issue. Anyways, I'm not sure this is a bug as perhaps "--opt=3" doesn't do anything in this case.

@drjdn drjdn added the bug label Jun 11, 2020
@chenyan2002
Copy link

I have the same question. --opt is in Cmd_arg.options, but not Cmd_arg.options_runtime_only. Is opt=3 enabled for building runtime anyway?

@hhugo
Copy link
Member

hhugo commented Sep 30, 2021

I believe this issue needs to be fixed while addressing ocaml/dune#1613

@hhugo
Copy link
Member

hhugo commented Dec 22, 2021

opt=3 would not do anything when building the runtime for separate compilation. That's why it's not included.
Starting with dune 3.0, jsoo flags handling will allow you to specify --opt=3 for js_of_ocaml compile only, as well as allowing to configure flags for the entire project (see ocaml/dune#5049)

@hhugo hhugo closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants