Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: allow tracking for manga chapters with {manga title} {chapter number} ... filename #328

Open
1 task done
tw8sqf3s opened this issue Feb 8, 2025 · 5 comments

Comments

@tw8sqf3s
Copy link

tw8sqf3s commented Feb 8, 2025

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe your suggested feature

examples:

  • Chainsaw Man 014 (2020) (foobar).cbz
  • Chainsaw Man 014.cbz

Additional Information

No response

Sample file

No response

@ollm ollm self-assigned this Feb 8, 2025
@ollm ollm added this to the v1.5.0 milestone Feb 8, 2025
@ollm
Copy link
Owner

ollm commented Feb 8, 2025

This should improve chapter detection ad05a23, you can try it in this build if you want to test.

Build: https://mega.nz/file/HeZTSAqT#JRJOyyBJf49QKNlCpnD54iAd9FeEMhTtjzdqDyB7sQg

@tw8sqf3s
Copy link
Author

tw8sqf3s commented Feb 9, 2025

it looks like it only detects 2 and 3 digit numbers but mangas like one piece have 4 digit chapter numbers
One Piece 1020 (2020) (foobar).cbz
One Piece 0001 (2020) (foobar).cbz

@ollm
Copy link
Owner

ollm commented Feb 9, 2025

I'm going to make some changes to fix it, I limited it to 2 and 3 digits to avoid detecting the year as a chapter number, in case the file name has something like this: Chainsaw Man 2020 (foobar).cbz

@tw8sqf3s
Copy link
Author

tw8sqf3s commented Feb 11, 2025

i don't think that a big problem because chapters years are in parentheses most of the time on a certain site

@ollm
Copy link
Owner

ollm commented Feb 11, 2025

I've changed it to detect 1-4 digit numbers 34fac61, the number must always be surrounded by spaces to be detected or at the end of the file name.

Build: https://mega.nz/file/eKQk3ZxL#JHmz2YrJ3DhJ6OFWwuX8KUjGm2JlGV6A0R6vjbQo2y8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants