Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: does not compile on host platform #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelMraka
Copy link

@MichaelMraka MichaelMraka commented Feb 13, 2025

fixing
Compiling .pioenvs/host-platform-bug/src/esphome/components/samsung_ac/debug_mqtt.o src/esphome/components/samsung_ac/debug_mqtt.cpp: In function ‘bool esphome::samsung_ac::debug_mqtt_connected()’: src/esphome/components/samsung_ac/debug_mqtt.cpp:18:17: error: ‘mqtt_client’ was not declared in this scope
18 | if (mqtt_client == nullptr)
| ^~~~~~~~~~~

📄 Description

What does this Pull Request do?

  • 🐞 Bug Fix
  • ✨ New Feature
  • 🔨 Code Improvement
  • 📚 Documentation Update

✨ Key Changes

ifdef's mqtt_client on (mqtt) unsupported platforms

🔗 Related Issues

Fixes: #262
Related:


Checklist

Please ensure the following before submitting your PR:

  • Code compiles without errors 🧑‍💻
  • All tests pass successfully ✅
  • Changes have been tested on relevant devices 🛠️
  • Documentation has been updated (if necessary) 📖
  • This PR is ready for review 🔍

🌐 Environment Information

🔢 Versions

  • ESPHome Version: 2024.10.2
  • Home Assistant Version:

🧩 Devices

  • Air Conditioner Type:
    • NASA
    • NON-NASA
    • Other
  • Air Conditioner Model: (e.g., AR09TXFCAWKNEU)
  • Outdoor Unit Model: (e.g., AJ050TXJ2KH/EA)
  • ESP Device Model: (e.g., M5STACK ATOM Lite + M5STACK RS-485)
  • Wiring Configuration: (e.g., F1/F2)

🧪 Test Plan

How were these changes tested?

  1. esphome compile bug.yaml

🔍 Logs


🛠️ YAML Configuration

# Please provide the relevant YAML configuration you used for testing this PR
esphome:
  name: host-platform-bug

host: # runs directly on x86_64
  mac_address: "12:34:56:78:90:ab"

uart:
  port: /dev/ttyUSB0
  baud_rate: 9600
  parity: EVEN

external_components:
  - source: github://omerfaruk-aran/esphome_samsung_hvac_bus@main

samsung_ac:
  devices:

fixing
Compiling .pioenvs/host-platform-bug/src/esphome/components/samsung_ac/debug_mqtt.o
src/esphome/components/samsung_ac/debug_mqtt.cpp: In function ‘bool esphome::samsung_ac::debug_mqtt_connected()’:
src/esphome/components/samsung_ac/debug_mqtt.cpp:18:17: error: ‘mqtt_client’ was not declared in this scope
   18 |             if (mqtt_client == nullptr)
      |                 ^~~~~~~~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug [Samsung_HVAC]: does not compile on host platform
1 participant