Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: check api token for coverage and gas report #613

Merged
merged 4 commits into from
Apr 10, 2020
Merged

chore: check api token for coverage and gas report #613

merged 4 commits into from
Apr 10, 2020

Conversation

boolafish
Copy link
Contributor

@boolafish boolafish commented Apr 7, 2020 •
edited
Loading

Note

  • Checks whether token api exist (env var) before submitting request (For Codecheck and coverall). Since fork or private mirror repo would not have have the privilege to use them.
  • Put coverage result and gas report to CircleCI artifact. So you can see the result there too.
  • Let eth-gas-reporter output to file instead of stdout, allowing saving to artifact though the format is not great 🙁 (It prints prettily in shell with less or cat commands, but not in Ide or vim)
  • coverage artifact example: index.html, circleCI link, this one is pretty good IMO

closes: #419
closes: https://github.com/omisego/plasma-contracts-private/issues/3

Test

CI passes for this repo, private mirror and from fork.

@boolafish boolafish force-pushed the boolafish/ci_disable_report_if_no_token branch 2 times, most recently from 4ea5dfc to fa9debe Compare April 7, 2020 06:08
@boolafish
chore: check api token for coverage and gas report
ca10f4f 
If using fork or private mirror repo, the CI job would not be able to submit with the token accordingly.
This commit omit the submission to codecheck and coverall if without token.
@boolafish boolafish force-pushed the boolafish/ci_disable_report_if_no_token branch 5 times, most recently from 1e994c3 to d66dee9 Compare April 7, 2020 07:39
boolafish added 3 commits April 7, 2020 16:47
@boolafish
chore: save coverage file to artifect
64e13f5
@boolafish
chore: save gas report to artifect
ee32af0
@boolafish
chore: output gas report to file instead of stdout
d7f8c03 
This commit change the gas report output to a file. However, even it is state in the document that it should be
RST format, it does not read that well. It read best in terminal somehow. Thus use `cat` command to print the result in circleCI.

Also, send the gasReport.rst to circle ci artifect
@boolafish boolafish force-pushed the boolafish/ci_disable_report_if_no_token branch from d66dee9 to d7f8c03 Compare April 7, 2020 07:48
@boolafish boolafish requested review from kevsul, pik694 and a team April 7, 2020 09:04
pik694
pik694 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@pik694 pik694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boolafish boolafish requested review from a team and pgebal April 10, 2020 02:03
thec00n
thec00n approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@thec00n thec00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boolafish boolafish merged commit 0a25fcb into master Apr 10, 2020
@boolafish boolafish deleted the boolafish/ci_disable_report_if_no_token branch April 10, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thec00n thec00n thec00n approved these changes

@pik694 pik694 pik694 approved these changes

@kevsul kevsul Awaiting requested review from kevsul

@pgebal pgebal Awaiting requested review from pgebal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solve coverage CI would always fail when PR is from a fork
3 participants
@boolafish @thec00n @pik694