Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hex-identifiers directly #303

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Use hex-identifiers directly #303

merged 5 commits into from
Oct 11, 2019

Conversation

maxaleks
Copy link
Contributor

@maxaleks maxaleks commented Oct 9, 2019

No description provided.

@maxaleks maxaleks requested review from akolotov and varasev October 9, 2019 19:59
@varasev
Copy link
Contributor

varasev commented Oct 10, 2019

@maxaleks Please fix the syntax warnings Travis reported about

@varasev
Copy link
Contributor

varasev commented Oct 10, 2019

I think we should base this PR on the develop branch, not the master. Am I right, @akolotov ?

@varasev varasev requested a review from patitonar October 10, 2019 07:36
@varasev
Copy link
Contributor

varasev commented Oct 10, 2019 •
edited
Loading

These hashes could be hardcoded as well:

https://github.com/poanetwork/poa-bridge-contracts/blob/9a20b50640eff6f23bc57ac8fc0f809e831bc557/contracts/upgradeable_contracts/native_to_erc20/ClassicHomeBridgeNativeToErc.sol#L24-L25

https://github.com/poanetwork/poa-bridge-contracts/blob/9a20b50640eff6f23bc57ac8fc0f809e831bc557/contracts/upgradeable_contracts/ValidatorsFeeManager.sol#L8-L14

@varasev varasev self-requested a review October 10, 2019 11:12
varasev
varasev approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@varasev varasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rechecked all the hashes

@patitonar patitonar changed the base branch from master to develop October 10, 2019 19:55
patitonar
patitonar approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I changed the base branch to develop. Please fix the merge conflict. Then let's wait for @akolotov approval before merging

akolotov
akolotov reviewed Oct 11, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the merge conflict as it was mentioned Gerardo.

@akolotov akolotov merged commit 165d828 into develop Oct 11, 2019
@akolotov akolotov deleted the code-optimization branch October 11, 2019 08:36
@akolotov akolotov mentioned this pull request Nov 7, 2019
Merged
@akolotov akolotov mentioned this pull request Dec 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@akolotov akolotov akolotov approved these changes

@varasev varasev varasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxaleks @varasev @patitonar @akolotov