Add support for oracle gas price values not expressed in gwei #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patitonar
added
oracle
akolotov
requested changes
Jul 10, 2019
akolotov
requested changes
Jul 11, 2019
akolotov
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105
Env variables
HOME_GAS_PRICE_FACTORandFOREIGN_GAS_PRICE_FACTORwere added, also in Monitor some other env variables were added too to properly specify values for home and foreign sides.Now other gas price oracles as
https://ethgasstation.info/json/ethgasAPI.jsonare supported on Oracle, UI and Monitor. (For example using*_FACTOR=0.1)The implementation to fetch the values from the oracle is similar in all the bridge components, it could be extracted in the future once #8 is completed.
@phahulin Please check that the new env variables are correctly set on
deploymentfiles