Consistent variable naming #198
Conversation
CONFIGURATION.md
Outdated
| MONITOR_FOREIGN_START_BLOCK | The app will monitor transactions starting from this block | integer | ||
| MONITOR_VALIDATOR_HOME_TX_LIMIT | | integer | ||
| MONITOR_VALIDATOR_FOREIGN_TX_LIMIT | | integer | ||
| MONITOR_TX_NUMBER_THRESHOLD | | integer |
There was a problem hiding this comment.
These 3 variables need some description, it was not described in any documentation before, and I'm not exactly sure what is the purpose for these.
There was a problem hiding this comment.
MONITOR_VALIDATOR_HOME_TX_LIMIT - average gas usage of a transaction sent by a validator, it is used to estimate the number of transaction that can be paid by the validator.
MONITOR_VALIDATOR_FOREIGN_TX_LIMIT - average gas usage of a transaction sent by a validator, it is used to estimate the number of transaction that can be paid by the validator.
MONITOR_TX_NUMBER_THRESHOLD - if estimated number of transaction is equal to or below this value, the monitor will report that the validator has less funds than it is required.
| @@ -254,14 +227,10 @@ When running the processes, the following commands can be used to test functiona | |||
|
|
|||
| | Variable | Description | | |||
| |-------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | `HOME_RPC_URL` | The HTTPS URL(s) used to communicate to the RPC nodes in the Home network. | | |||
| | `FOREIGN_RPC_URL` | The HTTPS URL(s) used to communicate to the RPC nodes in the Foreign network. | | |||
| | `USER_ADDRESS` | An account - the current owner of coins/tokens. | | |||
There was a problem hiding this comment.
These parameters are for scripts that are using for testing. So, a separate .env file could be used there - cut copy of the .env file used to run the bridge. That's why it is important either to list the corresponding parameters here one more time or to have its own set of parameters that will be used only for testing.
There was a problem hiding this comment.
Done - I have rolled back the removal of these lines, only updating with proper prefix.
CONFIGURATION.md
Outdated
| MONITOR_FOREIGN_START_BLOCK | The app will monitor transactions starting from this block | integer | ||
| MONITOR_VALIDATOR_HOME_TX_LIMIT | | integer | ||
| MONITOR_VALIDATOR_FOREIGN_TX_LIMIT | | integer | ||
| MONITOR_TX_NUMBER_THRESHOLD | | integer |
There was a problem hiding this comment.
MONITOR_VALIDATOR_HOME_TX_LIMIT - average gas usage of a transaction sent by a validator, it is used to estimate the number of transaction that can be paid by the validator.
MONITOR_VALIDATOR_FOREIGN_TX_LIMIT - average gas usage of a transaction sent by a validator, it is used to estimate the number of transaction that can be paid by the validator.
MONITOR_TX_NUMBER_THRESHOLD - if estimated number of transaction is equal to or below this value, the monitor will report that the validator has less funds than it is required.
e2e-commons/docker-compose.yml
Outdated
| - REACT_APP_FOREIGN_GAS_PRICE_FALLBACK=5000000000 | ||
| - REACT_APP_FOREIGN_GAS_PRICE_UPDATE_INTERVAL=15000 | ||
| - REACT_APP_FOREIGN_GAS_PRICE_FACTOR=1 | ||
| - REACT_APP_COMMON_HOME_BRIDGE_ADDRESS=0x32198D570fffC7033641F8A9094FFDCaAEF42624 |
There was a problem hiding this comment.
Is it possible by somehow avoid usage of the REACT_APP_ prefix here? For example - to refer to an .env file here instead of the variables and use pre-processing before running docker-compose to generate proper variables with correct prefix?
|
@akolotov All the requested changes are addressed now. Do you have anything more to ask or change? |
|
the PR has been approved for the merge |
ERC20_TOKEN_ADDRESSwill be removed in separate issue/PR: Remove ERC20_TOKEN_ADDRESS from env variables #201