Fix suggested gas price in trasaction for ui production build #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated chrome driver version used in e2e tests that was failing. The reason the issue with |
akolotov
approved these changes
Oct 25, 2019
akolotov
added a commit
that referenced
this pull request
Nov 12, 2019
…230 * Support alternative receiver in Oracle (#221) * Support alternative receiver feature in Monitor (#223) * Support token migration (#224) * Fix suggested gas price in transaction for ui production build (#222) * Updated links to new repo with tokenbridge contracts (#226) * Update the contract's submodule to the release 3.2.0 (#228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the production build of the UI it was found that a huge number was suggested as gas price for the transaction.
The problem is present only in the production build of the UI, the
toHexmethod ofweb3-utilsreturns a wrong result only in the production build when the number provided is of the typebn.jswhich is used by web3.Example of result in dev build:
0x12a05f200Example of result in production build:
0x2231326130356632303022There is an issue created but it was not solved web3/web3.js#2775.
Passing the value as string works as workaround and avoids this problem.