-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternative receiver feature in Monitor #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
Oct 27, 2019
akolotov
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you think we need to wait for the merge of #221 before merging the changes for the monitor?
Yes, let's wait for #221 to be merged in case more changes are applied there. Then we can update this branch with develop and merge this changes |
# Conflicts: # contracts
This is ready to be merged |
akolotov
added a commit
that referenced
this pull request
Nov 12, 2019
…230 * Support alternative receiver in Oracle (#221) * Support alternative receiver feature in Monitor (#223) * Support token migration (#224) * Fix suggested gas price in transaction for ui production build (#222) * Updated links to new repo with tokenbridge contracts (#226) * Update the contract's submodule to the release 3.2.0 (#228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #221
The main changes to the monitor component were made on this commit: eef52e1
Included also a fix for the chromedriver used in e2e tests to avoid CI failing