Support token migration #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patitonar
added
oracle
akolotov
requested changes
Nov 4, 2019
akolotov
requested changes
Nov 6, 2019
akolotov
approved these changes
Nov 6, 2019
akolotov
added a commit
that referenced
this pull request
Nov 12, 2019
…230 * Support alternative receiver in Oracle (#221) * Support alternative receiver feature in Monitor (#223) * Support token migration (#224) * Fix suggested gas price in transaction for ui production build (#222) * Updated links to new repo with tokenbridge contracts (#226) * Update the contract's submodule to the release 3.2.0 (#228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes explained here https://forum.poa.network/t/migration-to-mcd-for-xdai-bridge/3136
The oracle
Transferwatcher will discard transfers that includes aTokensSwappedevent in the same transaction.The monitor was updated to also filter the
Transferevents that includes aTokensSwappedevent in the same transaction and to getTransferevents of previous token used to correctly calculate the results.Tested the implementation with MakerDAO contracts in Sokol - Kovan testnets:
Sai Address:
0xc4375b7de8af5a38a93548eb8453a498222c4ff2Dai Address:
0x1d7e3a1a65a367db1d1d3f51a54ac01a2c4c92ffScdMcdMigration Address:
0x97cb5a9abcdbe291d0cd85915fa5b08746fe948aHomeBridge:
0x6E4b2262CFD96Af188C2c3Aae21a24a53A88E9F4ForeignBridge:
0x4F7925718A2492BD41D77D9F81552535E72A2090migrateToMCD call:
0x332c540a8c711a680167088fdf3732399f33707f07a08f56dde41a4f0b9377ac