Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs and start block parameters in oracle deployment #235

Merged
merged 6 commits into from
Nov 15, 2019

Conversation

patitonar
Copy link
Contributor

Closes #233

This PR includes:

  • Send transfer watcher logs to remote if configured by also applying logger config to /oracle/docker-compose-transfer.yml file
  • Update variable names for start blocks parameter
  • If ORACLE_HOME_START_BLOCK or ORACLE_FOREIGN_START_BLOCK are set in playbook configuration the parameters won't be recalculated in oracle/scripts/getValidatorStartBlocks.js

@phahulin please confirm that the deployment and the oracle works correctly with this changes

@patitonar patitonar added the deployment related to deployment playbooks/scripts/configs label Nov 14, 2019
@patitonar patitonar self-assigned this Nov 14, 2019
@phahulin
Copy link
Contributor

phahulin commented Nov 14, 2019

Playbook worked, I did a few test transfers and they completed, ex.
Eth -> xDai: https://etherscan.io/tx/0xea4ba2cec581914fce38122a2fb8ef0f02c2ad8fa951fcb1f2c8a45b4393201c
xDai -> Eth: https://blockscout.com/poa/xdai/tx/0x1ea4f185aa627b5cc313773397fc387b26637d96bdadbaffdcb9087d5472f248/internal_transactions

However, I wonder why foreign:nonce key was not set in redis

root@redis:/data# redis-cli
127.0.0.1:6379> keys *
1) "erc-native-transfer:lastProcessedBlock"
2) "home:nonce"
3) "erc-native-collected-signatures:lastProcessedBlock"
4) "erc-native-signature-request:lastProcessedBlock"
5) "erc-native-affirmation-request:lastProcessedBlock"

Does it use the same value on both sides of the bridge now? That's because our validator didn't have luck to generate token transfers on mainnet

- name: Write new docker-compose-extended file
copy:
content: "{{ docker_compose_extended_parsed | to_yaml }}"
dest: "{{ bridge_path }}/oracle/docker-compose-transfer.yml"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file deployment-e2e/molecule/oracle/tests/test_oracle.py we have only checks that rsyslog configuration files exist after the deployment. Does it make sense to extend the tests to detect issues similar to that it is being addressed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think there's room for improvement in the tests. Let's create a new issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment related to deployment playbooks/scripts/configs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants