-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logs and start block parameters in oracle deployment #235
Conversation
Playbook worked, I did a few test transfers and they completed, ex.
|
- name: Write new docker-compose-extended file | ||
copy: | ||
content: "{{ docker_compose_extended_parsed | to_yaml }}" | ||
dest: "{{ bridge_path }}/oracle/docker-compose-transfer.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the file deployment-e2e/molecule/oracle/tests/test_oracle.py
we have only checks that rsyslog configuration files exist after the deployment. Does it make sense to extend the tests to detect issues similar to that it is being addressed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think there's room for improvement in the tests. Let's create a new issue for this.
Closes #233
This PR includes:
transfer
watcher logs to remote if configured by also applying logger config to/oracle/docker-compose-transfer.yml
fileORACLE_HOME_START_BLOCK
orORACLE_FOREIGN_START_BLOCK
are set in playbook configuration the parameters won't be recalculated inoracle/scripts/getValidatorStartBlocks.js
@phahulin please confirm that the deployment and the oracle works correctly with this changes