Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in initialization of array to iterate getting signatures #240

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Changes in initialization of array to iterate getting signatures #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7407dab
another init of array to iterate getting signatures
akolotov Nov 18, 2019
45f2bfb
lint issue
akolotov Nov 18, 2019
cc061e2
logging changed
akolotov Nov 18, 2019
cf34dd5
make logging consistent
akolotov Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion oracle/src/events/processAMBCollectedSignatures/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ function processCollectedSignaturesBuilder(config) {
logger.info(`Processing CollectedSignatures ${colSignature.transactionHash}`)
const message = await homeBridge.methods.message(messageHash).call()

const requiredSignatures = new Array(NumberOfCollectedSignatures).fill(0)
logger.debug({ NumberOfCollectedSignatures }, 'Number of signatures to get')

const requiredSignatures = []
requiredSignatures.length = NumberOfCollectedSignatures
requiredSignatures.fill(0)

const signaturesArray = []
const [v, r, s] = [[], [], []]
Expand Down
6 changes: 5 additions & 1 deletion oracle/src/events/processCollectedSignatures/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ function processCollectedSignaturesBuilder(config) {
logger.info(`Processing CollectedSignatures ${colSignature.transactionHash}`)
const message = await homeBridge.methods.message(messageHash).call()

const requiredSignatures = new Array(NumberOfCollectedSignatures).fill(0)
logger.debug({ NumberOfCollectedSignatures }, 'Number of signatures to get')

const requiredSignatures = []
requiredSignatures.length = NumberOfCollectedSignatures
requiredSignatures.fill(0)

const [v, r, s] = [[], [], []]
logger.debug('Getting message signatures')
Expand Down