Fix home gas price fallback value usage in monitor #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
Dec 28, 2019
There was a problem hiding this comment.
@patitonar I think the original issue was against the fact that we don't need to monitor the validator's balance on the xDai chain at all. These accounts are whitelisted in the the consensus contracts that's why they could send transactions with the zero gas price.
In order to disable the validator's balance check let's reuse MONITOR_VALIDATOR_*_TX_LIMIT variables. If the variable is set to 0 or undefined, the check will be disabled and results.homeOk/results.foreignOk will be always true in this case.
|
Thanks for the explanation! Closed in favor of #259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237
If
COMMON_HOME_GAS_PRICE_FALLBACKis set to0theleftTxattribute will be set to a very big number as specified in this change #142 (comment) , so thenresults.homeOkwill be true when validators have0balance as in xDai Chain.Most of the logic was in place, this PR only fixes the precedence order of the gas price parameters used in the calculation