Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle & Monitor - Compiled ABI's #71

Merged
merged 8 commits into from
May 27, 2019
Merged

Oracle & Monitor - Compiled ABI's #71

merged 8 commits into from
May 27, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented May 24, 2019 •
edited
Loading

Work done:

  • Removed ABI's checked into source control
  • Sourcing ABI's from contracts for oracle and monitor
  • Changed script name from compile:contracts to import:contracts in oracle, monitor and ui
  • Modified oracle/Dockerfile to include compiled contracts
  • Extracted project setup steps from Dockerfile.e2e into package.json scripts install:deploy and prepare:contracts so that the same scripts will be used outsite e2e tests.

@rzadp
Oracle abi taken from compilation.
3bba9c6 
Moved project setup from dockerfile to package.json scripts
@rzadp rzadp added oracle related to TokenBridge oracle shared shared components contracts related to poa-bridge-contracts labels May 24, 2019
@rzadp rzadp marked this pull request as ready for review May 24, 2019 13:00
@rzadp rzadp requested review from akolotov and patitonar May 24, 2019 13:00
akolotov
akolotov requested changes May 24, 2019
View reviewed changes
@rzadp rzadp requested a review from akolotov May 25, 2019 19:01
akolotov
akolotov approved these changes May 25, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@rzadp rzadp merged commit f5ff33d into master May 27, 2019
@rzadp rzadp deleted the oracle-abi branch May 27, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

@patitonar patitonar Awaiting requested review from patitonar

Assignees
No one assigned
Labels
contracts related to poa-bridge-contracts oracle related to TokenBridge oracle shared shared components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract repeated submodules/poa-bridge-contracts into one in root dir
2 participants
@rzadp @akolotov