Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable port #76

Merged
merged 3 commits into from
May 30, 2019
Merged

Configurable port #76

merged 3 commits into from
May 30, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented May 28, 2019 •
edited
Loading

Fixes #34

  • Changed monitor to listed on 3003 on default (in order to not interfere with ui-e2e that occupy 3000, 3001 and 3002)
  • ui still listens on 3000 but in a more explicit way instead of a react-app-rewired's default

@rzadp rzadp added UI related to TokenBridge UI monitor related to TokenBridge monitor labels May 28, 2019
@rzadp rzadp marked this pull request as ready for review May 28, 2019 13:11
@rzadp rzadp requested review from akolotov and patitonar May 28, 2019 13:11
@rzadp rzadp merged commit 1ab4a0e into master May 30, 2019
@rzadp rzadp deleted the configurable-port branch May 30, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@akolotov akolotov akolotov approved these changes

Assignees
No one assigned
Labels
monitor related to TokenBridge monitor UI related to TokenBridge UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the port to listen configurable
3 participants
@rzadp @patitonar @akolotov