-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AWS, Extensions.AWSXRay] Add net6.0 target, replace net452 target with net462 #1093
[Instrumentation.AWS, Extensions.AWSXRay] Add net6.0 target, replace net452 target with net462 #1093
Conversation
Add a .NET 6.0 target to improve the dependency graph combined with Extensions.AWSXRay when consumers target modern .NET runtimes. * .NET Framework 4.5.2 is no longer supported. Replace it with the oldest supported version, 4.6.2, and update conditional compilation symbols in the tests project. * Add a net7.0 test target to match Extensions.AWSXRay.Tests. * Keep the netcoreapp3.1 test target to exercise the library's netstandard2.0 build. * In the tests project, suppress the build warning generated by System.Diagnostics.DiagnosticSource 7.0.0 when targeting out-of-support frameworks. * Remove the tests' now-unnecessary reference to System.Net.Http.
Add a .NET 6.0 build target to improve the transitive dependency graph for consumers targeting newer runtimes. * Add a netcoreapp3.1 test target to exercise the library's netstandard2.0 build. * In the tests project, suppress the build warning generated by System.Diagnostics.DiagnosticSource 7.0.0 when targeting out-of-support frameworks.
* Previously, constructing the Resource in AWSLambdaResourceDetector would throw should any of the environment variables be null. Make that condition explicit by pro-actively throwing a descriptive exception. * Change the type of ValidationCallback to match HttpClientHandler's callback delegate type, which clarifies that the certificate is an instance of X509Certificate2. * Check that 'cert' and 'chain' are non-null before performing validation steps that require them.
@vishweshbankwar I noticed that no tests were run for the Personally, given the fact there are no more supported runtimes that need it, I think it makes more sense to remove the |
@wjrogers Can you describe the reason why you are adding net6.0 target? Are you leveraging any new APIs/Features from net6.0? |
@cijothomas Sure. This PR is meant to combine with #1092 to remove a dependency when targeting It's not strictly required to target |
@wjrogers Thanks for the explanation. Could you update the PR description so its easy to why is this needed. And also I'd suggest to make the net452->net462 into a separate PR of its own. |
Have now done so as #1095. I will refresh this PR to isolate the |
I am closing this PR so I can push a new branch that affects only Extensions.AWSXRay, with a more interesting justification. I will follow up on Instrumentation.AWS if/when my other PRs are accepted. |
continued in #1096 |
Fixes #1078.
Changes
Add a
net6.0
target to OpenTelemetry.Contrib.Instrumentation.AWS and OpenTelemetry.Contrib.Extensions.AWSXRay. Also, update the former's out-of-supportnet452
target tonet462
, i.e.NetFrameworkMinimumSupportedVersion
. I combined the updates to these two projects into one PR because the latter is a dependency of the former.NET452
toNETFRAMEWORK
.net7.0
test target to Instrumentation.AWS.Tests to match Extensions.AWSXRay.Tests.netcoreapp3.1
test target to Extensions.AWSXRay to exercise the library'snetstandard2.0
target.