-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Add dedicated CI for AspNet projects #1386
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
- Coverage 73.91% 73.76% -0.16%
==========================================
Files 267 258 -9
Lines 9615 9551 -64
==========================================
- Hits 7107 7045 -62
+ Misses 2508 2506 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, we have had technically two release on the GH side, now we will have only one with link to the AspNet project. Changelog for TelemetryModule will be not linked.
Ref: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases/tag/Instrumentation.AspNet.TelemetryHttpModule-1.0.0-rc9.9 and https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases/tag/Instrumentation.AspNet-1.0.0-rc9.9
It will be great to have two of them in on GH release. I think it can be done in follow up PR.
Good call @Kielek! I'll look into it a bit. |
@Kielek I just pushed support for including multiple packages in the GitHub release created by the package workflow. |
I realized there is one more issue with this. Here... opentelemetry-dotnet-contrib/.github/workflows/Component.Package.yml Lines 35 to 36 in 37d430d
...we only test the AspNet project. I need to switch it to test all projects (HttpModule too). To do that I have to tweak all the |
Changes
Component.Package.yml
to support multiple packages being released from the same tag.Details
Why switch to a single tag?
If
AspNet.TelemetryHttpModule
is being changed, we always want to also pushAspNet
.If
AspNet
is being changed, we could run into trouble without also pushingAspNet.TelemetryHttpModule
. For something like a pure bug fix, it would be fine to only pushAspNet
. However,AspNet
gets its OTel API and DS references through the HttpModule project. It also directly depends on the exposedAspNet.TelemetryHttpModule
APIs. IfAspNet.TelemetryHttpModule
was changed, for example do to an OTel API version bump, theAspNet
package will be compiled against those bits but packaged targeting whatever the last tag was (older bits). Users consuming that package could run into big issues. Pushing the two packages together makes it always safe without having to worry about what may be lurking in the repo.