Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Add dedicated CI for persistent storage projects #1397

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

CodeBlanch
Copy link
Member

Changes

  • Adds dedicated CI for PersistentStorage projects.
  • Switches to a single tag for Abstractions & FileSystem projects so that they will always be released together.
  • Adds missing AspNet path filters in the main CI workflow (missed on [repo] Add dedicated CI for AspNet projects #1386)

@CodeBlanch CodeBlanch added comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions labels Oct 13, 2023
@CodeBlanch CodeBlanch requested a review from a team October 13, 2023 03:49
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1397 (a4b6fa2) into main (71655ce) will decrease coverage by 0.11%.
Report is 29 commits behind head on main.
The diff coverage is 68.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   73.91%   73.81%   -0.11%     
==========================================
  Files         267      261       -6     
  Lines        9615     9608       -7     
==========================================
- Hits         7107     7092      -15     
- Misses       2508     2516       +8     
Flag Coverage Δ
unittests-Exporter.Geneva 58.05% <25.00%> (?)
unittests-Exporter.OneCollector 89.71% <ø> (?)
unittests-Instrumentation.AspNet 70.90% <100.00%> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 75.88% <ø> (?)
unittests-Instrumentation.Wcf 79.01% <82.27%> (?)
unittests-PersistentStorage 58.80% <ø> (?)
unittests-Solution 80.02% <43.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...orter.Geneva/MsgPackExporter/MsgPackLogExporter.cs 95.10% <100.00%> (+1.76%) ⬆️
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs 100.00% <100.00%> (ø)
...ation.AspNet.TelemetryHttpModule/ActivityHelper.cs 85.24% <100.00%> (ø)
...searchClient/ElasticsearchClientInstrumentation.cs 100.00% <100.00%> (ø)
...ityFrameworkCore/EntityFrameworkInstrumentation.cs 100.00% <100.00%> (ø)
...ation/EntityFrameworkInstrumentationEventSource.cs 12.00% <100.00%> (ø)
...ation.Owin/Implementation/DiagnosticsMiddleware.cs 89.42% <100.00%> (-2.44%) ⬇️
....Owin/Implementation/OwinInstrumentationMetrics.cs 100.00% <100.00%> (ø)
...inInstrumentationMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...Instrumentation.Quartz/QuartzJobInstrumentation.cs 83.33% <100.00%> (+1.51%) ⬆️
... and 20 more

... and 36 files with indirect coverage changes

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am not sure if we always need to release both oaclages together, but if you think so, we can ,merge as is.

@CodeBlanch
Copy link
Member Author

@Kielek We don't technically have to release them together, but I think doing so simplifies things and reduces the chance of any issues.

These packages are very similar to the Microsoft.Extensions.FileProviders.* suite which do the same thing: https://github.com/dotnet/runtime/blob/fe1247b23edc015bd2149536dee533f912035efa/src/libraries/Microsoft.Extensions.FileProviders.Physical/src/Microsoft.Extensions.FileProviders.Physical.csproj#L25-L27

I think the general wisdom to be gleamed from runtime team here is that it is better to release the whole graph together instead of trying to micro-manage the versions.

We could always make it more granular if a strong need arises.

@utpilla utpilla changed the title [repo] Add dedicated storage for persistent storage projects [repo] Add dedicated CI for persistent storage projects Oct 13, 2023
@Kielek Kielek merged commit 4db5ac6 into open-telemetry:main Oct 14, 2023
@CodeBlanch CodeBlanch deleted the ci-persistentstorage branch October 16, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants