-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Enable package validation #1710
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
+ Coverage 73.91% 74.70% +0.78%
==========================================
Files 267 291 +24
Lines 9615 11392 +1777
==========================================
+ Hits 7107 8510 +1403
- Misses 2508 2882 +374
Flags with carried forward coverage won't be shown. Click here to find out more. |
No possibility to build .NET Framework on Linux
to download baseline package
Both can be removed when we will have first release in contrib repository
it was leading to error NU5128: Warning As Error: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location.
can be removed when we have first release with common PersistentStorage- tag, Previously it was using separate tags
…or official builds.
@Kielek I pushed a couple tweaks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@CodeBlanch, thanks for additional fixes! |
Fixes #1680.
Towards: open-telemetry/opentelemetry-dotnet#5526
Changes
Enable package validation based on already released stable packages.
Note
Only added to the new pipeline. Old pipelines remains unchanged.
I hope we will rewrite all packages to the new style at some point.
Fixes also pack/release process for PersistentStorage packages. Issue introduced in #1397
Important
@open-telemetry/dotnet-contrib-maintainers, releasing process changed. If you releasing stable package, you need to update csproj file with the new version.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed