Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Enable package validation #1710

Merged
merged 14 commits into from
May 10, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 9, 2024

Fixes #1680.
Towards: open-telemetry/opentelemetry-dotnet#5526

Changes

Enable package validation based on already released stable packages.

Note

Only added to the new pipeline. Old pipelines remains unchanged.

I hope we will rewrite all packages to the new style at some point.

Fixes also pack/release process for PersistentStorage packages. Issue introduced in #1397

Important

@open-telemetry/dotnet-contrib-maintainers, releasing process changed. If you releasing stable package, you need to update csproj file with the new version.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek added the infra Infra work - CI/CD, code coverage, linters label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (71655ce) to head (11aa88c).
Report is 229 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
+ Coverage   73.91%   74.70%   +0.78%     
==========================================
  Files         267      291      +24     
  Lines        9615    11392    +1777     
==========================================
+ Hits         7107     8510    +1403     
- Misses       2508     2882     +374     
Flag Coverage Δ
unittests-Exporter.Geneva 63.89% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.83% <ø> (?)
unittests-Instrumentation.AspNet 74.69% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 81.96% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 52.38% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 261 files with indirect coverage changes

No possibility to build .NET Framework on Linux
Both can be removed when we will have first release in contrib repository
Kielek added 2 commits May 9, 2024 10:21
it was leading to error NU5128: Warning As Error: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location.
can be removed when we have first release with common PersistentStorage- tag, Previously it was using separate tags
@Kielek Kielek marked this pull request as ready for review May 9, 2024 08:51
@Kielek Kielek requested a review from a team May 9, 2024 08:51
@CodeBlanch
Copy link
Member

@Kielek I pushed a couple tweaks.

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title Package validation [repo] Enable package validation May 9, 2024
@Kielek
Copy link
Contributor Author

Kielek commented May 10, 2024

@CodeBlanch, thanks for additional fixes!

@Kielek Kielek merged commit 707f575 into open-telemetry:main May 10, 2024
154 checks passed
@Kielek Kielek deleted the package-validation branch May 10, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[repo] Enable package validation
10 participants