We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up to #2220
I think we should remove the Cow, and make scope take owned versions. Scopes are created only very few times in the app, so there should not be perf concerns. https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/common.rs#L422
if perf is a concern, we can make Instrumentation Scope be an Arc of InstrumentationScopeInner to make cloning cheap.
The text was updated successfully, but these errors were encountered:
@stormshield-fabs I think you mentioned this in the PR but i am not able to locate that comment now! Can you help check if this cleanup is needed?
Sorry, something went wrong.
tagging for 0.27 as we want to avoid breaking changes after 0.27
This was brought up in #2220 (comment)
Thanks! I was searching for it, but wasn't able to locate easily!! Would you be able to address this?
Successfully merging a pull request may close this issue.
Follow up to #2220
I think we should remove the Cow, and make scope take owned versions. Scopes are created only very few times in the app, so there should not be perf concerns.
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/common.rs#L422
if perf is a concern, we can make Instrumentation Scope be an Arc of InstrumentationScopeInner to make cloning cheap.
The text was updated successfully, but these errors were encountered: