Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation Scope and cloning #2246

Closed
cijothomas opened this issue Oct 25, 2024 · 4 comments · Fixed by #2275
Closed

Instrumentation Scope and cloning #2246

cijothomas opened this issue Oct 25, 2024 · 4 comments · Fixed by #2275
Milestone

Comments

@cijothomas
Copy link
Member

Follow up to #2220

I think we should remove the Cow, and make scope take owned versions. Scopes are created only very few times in the app, so there should not be perf concerns.
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/common.rs#L422

if perf is a concern, we can make Instrumentation Scope be an Arc of InstrumentationScopeInner to make cloning cheap.

@cijothomas
Copy link
Member Author

@stormshield-fabs I think you mentioned this in the PR but i am not able to locate that comment now! Can you help check if this cleanup is needed?

@cijothomas cijothomas added this to the 0.27 milestone Oct 25, 2024
@cijothomas
Copy link
Member Author

tagging for 0.27 as we want to avoid breaking changes after 0.27

@stormshield-fabs
Copy link
Contributor

This was brought up in #2220 (comment)

@cijothomas
Copy link
Member Author

This was brought up in #2220 (comment)

Thanks! I was searching for it, but wasn't able to locate easily!!
Would you be able to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants