Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Proxy Global Ban Keys not being obeyed at KeyCheck #1159

Open
5 tasks done
frozen-cdn opened this issue Feb 5, 2025 · 1 comment
Open
5 tasks done

[Bug]: Proxy Global Ban Keys not being obeyed at KeyCheck #1159

frozen-cdn opened this issue Feb 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@frozen-cdn
Copy link

frozen-cdn commented Feb 5, 2025

This issue respects the following points:

  • This is a bug, not a question or a configuration issue; Please visit our forum first to troubleshoot with volunteers, before creating a report. The links can be found here.
  • This issue is not already reported on GitHub (I've searched it).
  • I'm using an up to date version of OpenBullet2. We generally do not support previous older versions. If possible, please update to the latest version before opening an issue.
  • I agree to follow OpenBullet's Code of Conduct.
  • This report addresses only a single issue; If you encounter multiple issues, kindly create separate reports for each one.

Description of the bug

Hello again friends

I added </html> to the Global Ban Keys section under Proxies, and the documentation says it's a way to not have to add terms to every KeyCheck which sounded great, so I added to it as a way to filter out Proxies that keep giving bad responses, but it doesn't appear to work, and instead is heading to my CUSTOM area where I am doing further troubleshooting.

Image

But I expect this to receive BAN status, not CUSTOM! As </html> is already specified in Global Ban Keys. And then when something doesn't contain my terms it's supposed to go to Custom afterwards, but not before being filtered by the Global Ban Key. Only way I can figure out to fix it is to add the </html> tag above the CUSTOM check, but isn't that what exactly what it's supposed to save time from?

Let me know what I misunderstood, or if this is a bug

Thanks as always

Reproduction steps

Add </html> to Proxy Global Ban Keys
Receive a response with </html> and notice it is not caught by Global Ban Key Check

What is the current bug behavior?

Not working

What is the expected correct behavior?

Catch the Global Ban Key at KeyCheck time, as per the documentation

Version of the client

Latest

Type of client

Web client

Environment

- OS: Win11
- Virtualization: Proxmox
- Browser: Chrome

OpenBullet2 logs

Client / Browser logs

No response

Relevant screenshots or videos

No response

Relevant LoliCode if needed

Additional information

No response

@frozen-cdn frozen-cdn added the bug Something isn't working label Feb 5, 2025
@frozen-cdn
Copy link
Author

frozen-cdn commented Feb 5, 2025

Global ban keys
In the global ban keys field you can write a list of keywords (one per line) that indicate that a proxy should be banned. Usually, these include keywords that indicate the presence of a captive portal or region-based access control of some sort. This is a way to ban free low-quality proxies without the need to put all those keywords inside the Keycheck block of your configs.

These keys will be checked when executing a Keycheck block, and if they are present in the data.SOURCE variable, they will lead to a BAN status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant