Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom cache headers set by one component could appear as a cache headers for another #327

Closed
i-b-dimitrov opened this issue Dec 8, 2016 · 1 comment
Labels

Comments

@i-b-dimitrov
Copy link
Contributor

@matteofigus

We found a bug introduced in #326 - the problem is on line 30 in get-component.js file. There we introduced responseHeaders variable but this is in a outerer context than it should be. Because of this every invocation of render sees one and the same variable and every component inherits the headers introduced by former ones.
The fix is to move the responseHeaders variable inside renderer function.

I'm basically having the fix and am working on a regression test to validate it. Perhaps tomorrow I'll do a PR.

@matteofigus
Copy link
Member

Ok, thanks. We haven't tested this version yet but planning to do next week. In case I'll wait for the fix!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants