Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-components-by-dir issue #476

Closed
mattiaerre opened this issue Apr 27, 2017 · 1 comment
Closed

get-components-by-dir issue #476

mattiaerre opened this issue Apr 27, 2017 · 1 comment
Assignees

Comments

@mattiaerre
Copy link
Member

Description

after the release v0.36.16, if you try to run oc dev . where there is a folder w/ a package.json file in it and this folder doesn't contain a component, you get the following error:

Cannot read property 'files' of undefined

this is because the function isOcComponent returns true also if the oc section is missing in the package.json.

I believe that the problem has been introduced w/ this PR:

#447

and in particular:

https://github.com/opentable/oc/pull/447/files#diff-6810304ebc65ef9905ca3d7d77d8a311

@mattiaerre
Copy link
Member Author

I am going to create a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant