Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move husky scripts to where they're expected #961

Closed
elboletaire opened this issue Nov 9, 2018 · 0 comments · Fixed by #1192
Closed

Move husky scripts to where they're expected #961

elboletaire opened this issue Nov 9, 2018 · 0 comments · Fixed by #1192
Labels

Comments

@elboletaire
Copy link
Collaborator

Who is the bug affecting?

Everyone who tries to change OC code.

What is affected by this bug?

Everytime you try to commit/push code, husky complains about where scripts are located.

When does this occur?

git commit & git push

Where on the platform does it happen?

<root>

How do we replicate the issue?

  1. Clone the repo
  2. npm i
  3. echo 'whatever' >> README.md
  4. git add README.md
  5. git commit -m "Trying to commit"

The latest command passes if you're using node > 8, but shows these notes:

Warning: Setting pre-commit script in package.json > scripts will be deprecated
Please move it to husky.hooks in package.json, a .huskyrc file, or a husky.config.js file
Or run ./node_modules/.bin/husky-upgrade for automatic update

Expected behavior (i.e. solution)

Moving hasky-specific scripts to a hasky key inside package.json should fix the issues.

Note that, as said, commits cannot pass if you're using node < 8.

What version of OC, Node.js and OS are you using?

  • OC: From git, at HEAD
  • Node.js: Version 6, as specified in .nvmrc. As said, using version > 8 allows the commit to pass.
  • OS: Ubuntu 18.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant