Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[ethcore-builtin]: use TryFrom instead of From #11134

Closed
niklasad1 opened this issue Oct 6, 2019 · 0 comments · Fixed by #11140
Closed

[ethcore-builtin]: use TryFrom instead of From #11134

niklasad1 opened this issue Oct 6, 2019 · 0 comments · Fixed by #11140
Labels
hacktoberfest Join us for hacktoberfest - https://substrate.dev/hacktoberfest/ P7-nicetohave 🐕 Issue is worth doing eventually. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either

Comments

@niklasad1
Copy link
Collaborator

niklasad1 commented Oct 6, 2019 •
edited
Loading

Instead of panicking when faulty builtin names are entered in the chain spec, replace the From implementation with TryFrom and propagate the error accordingly
@niklasad1 niklasad1 added P7-nicetohave 🐕 Issue is worth doing eventually. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either labels Oct 6, 2019
@dvdplm dvdplm added the hacktoberfest Join us for hacktoberfest - https://substrate.dev/hacktoberfest/ label Oct 7, 2019
@rokob rokob mentioned this issue Oct 8, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
hacktoberfest Join us for hacktoberfest - https://substrate.dev/hacktoberfest/ P7-nicetohave 🐕 Issue is worth doing eventually. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TryFrom instead of From+panic for Builtin rokob/parity-ethereum
2 participants
@dvdplm @niklasad1