Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Avoid repeated delete calls for the stale segment files #11530

Closed
sachinpkale opened this issue Dec 8, 2023 · 0 comments
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework untriaged

Comments

@sachinpkale
Copy link
Member

  • Currently, we trigger cleanup of stale segment files from remote segment store on each flush.
  • This clean-up is based on metadata file which references to the segment file
  • If multiple stale segment metadata files refer to the same segment file, we call remoteDataDirectory.deleteFile multiple times.
  • Functionally, this is a no-op as RemoteDirectory internally calls blobContainer.deleteBlobsIgnoringIfNotExists.
  • But this can still make a call to the remote store which is un-necessary.
  • We need to keep track of deleted files and avoid calling delete on the same deleted file.
@sachinpkale sachinpkale added enhancement Enhancement or improvement to existing feature or request untriaged labels Dec 8, 2023
@sachinpkale sachinpkale self-assigned this Dec 8, 2023
@sachinpkale sachinpkale added Storage:Durability Issues and PRs related to the durability framework and removed untriaged labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework untriaged
Projects
None yet
Development

No branches or pull requests

1 participant