Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSink to use Event model #606

Closed
chenqi0805 opened this issue Nov 16, 2021 · 1 comment · Fixed by #750
Closed

FileSink to use Event model #606

chenqi0805 opened this issue Nov 16, 2021 · 1 comment · Fixed by #750
Assignees
@chenqi0805
Labels
enhancement New feature or request plugin - sink A plugin to write data to a destination.

Comments

@chenqi0805
Copy link
Collaborator

chenqi0805 commented Nov 16, 2021 •
edited by cmanning09
Loading

Is your feature request related to a problem? Please describe.
Follow up on Event model change #538 to migrate the FileSink.

Describe the solution you'd like
This sink should implement should utilized events: ... implements Sink<Record<Event>> {

Additional context
This plugin will move to only Event's when the Recordis fully deprecated in v2.0
@dlvenable dlvenable mentioned this issue Nov 16, 2021
Closed
@cmanning09 cmanning09 added enhancement New feature or request plugin - sink A plugin to write data to a destination. and removed untriaged labels Nov 17, 2021
@cmanning09
Copy link
Contributor

updated description

@chenqi0805 chenqi0805 self-assigned this Dec 15, 2021
@chenqi0805 chenqi0805 mentioned this issue Dec 15, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenqi0805 chenqi0805

Labels
enhancement New feature or request plugin - sink A plugin to write data to a destination.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: file sink to support Event model chenqi0805/data-prepper
2 participants
@cmanning09 @chenqi0805