-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The name disappears after entering a dash #7536
Comments
Thanks for reporting @maro-21 .. The endash is used as special separator character in the name dropdown for a few old reasons. Name suggestion presets sometimes need to disambiguate between several choices like “7-Eleven – Fuel” and “7-Eleven – Convenience Store”. Because names can have hyphens in them and the dropdown control only lets us work with a single text value, and the preset part of the name needs to be localized, we are using the endash as a separator. It would be ideal if you can use a different separator character in your bus stop names. For example, it’s common in places like Belgium to represent multilingual names like “French - Dutch” with a standard hyphen between. |
Looks like this bug only occurs if there are spaces surrounding the en dash, possibly due to that conflict with the name suggestion feature mentioned above, but it occurs even if there’s no name suggestion preset. iD/modules/ui/sections/feature_type.js Lines 102 to 103 in 60f7dc7
Assuming it is due to the name suggestion preset feature, could that feature format the disambiguators differently? Some languages, such as Chinese, use en dashes in everyday usage and don’t consider hyphens to be a substitute. name-suggestion-index already uses parentheses to disambiguate identically tagged presets in different countries. But there are other options for disambiguating tags that would be less likely to conflict with things users may be in the habit of entering manually; possibilities include a swung dash (⁓), bullet (•), or square brackets ([…]). |
We could probably delimit on some nonprintable Unicode characters in the string to avoid the issue. The important thing is that the decorated string looks normal to the user and to html, because it will appear in dropdowns, preset labels, etc, and we will have to find it later to remove the decoration. |
I ended up making |
I wanted to change the name of a bus stop:
What I wanted to do was change the hyphen to the dash in the name:
No matter what I do or where I click, the name after the dash disappears and only "Volvo" remains:
I can edit the name only in All Tags section.
The text was updated successfully, but these errors were encountered: